upgrade mysql:mysql-connector-java to 8.2.0 #16024
Conversation
|
Similar work happening in this PR as well: https://github.com/apache/druid/pull/15408/files |
AlbericByte
changed the title
|
|
||
| @Test | ||
| public void testWhenInvalidUrlFormat() | ||
| { |
There was a problem hiding this comment.
The parser no longer checks if every component is in the expected format it only checks if the URL starts with one of the required schema i.e jdbc:mysql,jdbc:mysql:loadbalancer, etc. So we will not be able to determine if this is a valid/invalid URL just by using the parser.
The way to determine if the URL is valid is by creating a connection with the DB.
😄
| Assert.assertTrue( | ||
| connector.connectorIsTransientException(new SQLException("some transient failure", "s0", 1317)) | ||
| ); | ||
| Assert.assertFalse( | ||
| connector.connectorIsTransientException(new SQLException("totally realistic test data", "s0", 1337)) | ||
| ); | ||
| // this method does not specially handle normal transient exceptions either, since it is not vendor specific | ||
| Assert.assertFalse( |
There was a problem hiding this comment.
why is it changed from assertFalse to assertTrue
There was a problem hiding this comment.
Thanks for your time first.
-
We changed MYSQL_TRANSIENT_EXCEPTION_CLASS_NAME from "com.mysql.jdbc.exceptions.MySQLTransientException" to "java.sql.SQLTransientException"
-
And in mysql-connector-j-8.2.0.jar, we do not have MySQLTransientException.
| @@ -338,29 +337,6 @@ public boolean isEnforceAllowedProperties() | |||
| ); | |||
| } | |||
|
|
|||
| @Test | |||
| public void testFindPropertyKeysFromInvalidConnectUrl() | |||
There was a problem hiding this comment.
it makes sense to remove this duplicate test
* upgrade mysql:mysql-connector-java to 8.2.0 * fix the check errors * remove unused comment (cherry picked from commit 92fb0ff)
Fixes #13389.
Description
upgrade the mysql:mysql-connector-java to 8.0.28
upgrade the package version
Release note
Upgrade mysql:mysql-connector-java to 8.0.28
Key changed/added classes in this PR
MySQLConnector.javaMySQLConnectorTest.javapom.xmlThis PR has: