-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KOGITO-9729] - (fix) Preserve directory structure while copying files in builder image #1711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s in builder image Signed-off-by: Ricardo Zanini <[email protected]>
2 tasks
jakubschwan
approved these changes
Nov 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
domhanak
approved these changes
Dec 1, 2023
ricardozanini
added a commit
to ricardozanini/incubator-kie-kogito-images
that referenced
this pull request
Dec 1, 2023
…s in builder image (apache#1711) Signed-off-by: Ricardo Zanini <[email protected]>
8 tasks
ricardozanini
added a commit
that referenced
this pull request
Dec 4, 2023
…s in builder image (#1711) (#1712) Signed-off-by: Ricardo Zanini <[email protected]>
rgdoliveira
pushed a commit
to kiegroup/kogito-images
that referenced
this pull request
Dec 11, 2023
…s in builder image (apache#1711) Signed-off-by: Ricardo Zanini <[email protected]>
rgdoliveira
pushed a commit
to kiegroup/kogito-images
that referenced
this pull request
Dec 11, 2023
[1.44.2.x-prod][KOGITO-9729] - (fix) Preserve directory structure while copying files in builder image (apache#1711)
rgdoliveira
pushed a commit
to kiegroup/kogito-images
that referenced
this pull request
Dec 13, 2023
…s in builder image (apache#1711) Signed-off-by: Ricardo Zanini <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://issues.redhat.com/browse/KOGITO-9729
Reopened because the other method was not working properly.
${swf_home_dir}
was not a valid variable or directory within the context.Additionally, now we copy the whole build context. We can't filter since users might upload XML, CSV, images or any other valid resources for their use cases.
Many thanks for submitting your Pull Request ❤️!
Please make sure your PR meets the following requirements:
[KOGITO|RHPAM-XYZ] Subject
How to retest this PR or trigger a specific build:
(Re)run Jenkins tests
Please add comment: Jenkins [test|retest] this
Prod tests
Please add comment: Jenkins (re)run [prod|Prod|PROD]
How to backport a pull request to a different branch?
In order to automatically create a backporting pull request please add one or more labels having the following format
backport-<branch-name>
, where<branch-name>
is the name of the branch where the pull request must be backported to (e.g.,backport-7.67.x
to backport the original PR to the7.67.x
branch).Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.