[INLONG-9893][Common] Optimized code InLongMsg (#9894)

Co-authored-by: [email protected] <[email protected]>
apache · Mar 31, 2024 · 595bb12 · 595bb12
1 parent 5b5eabb
commit 595bb12
Showing 1 changed file with 9 additions and 11 deletions.
diff --git a/inlong-common/src/main/java/org/apache/inlong/common/msg/InLongMsg.java b/inlong-common/src/main/java/org/apache/inlong/common/msg/InLongMsg.java
@@ -246,13 +246,9 @@ public boolean addMsg(String attr, ByteBuffer data) {
             return false;
         }
 
-        DataBuffer outputBuffer = attr2MsgBuffer.get(attr);
-        if (outputBuffer == null) {
-            outputBuffer = new DataBuffer();
-            attr2MsgBuffer.put(attr, outputBuffer);
-            // attrlen + utflen + meglen + compress
-            this.datalen += attr.length() + 2 + 4 + 1;
-        }
+        DataBuffer outputBuffer = attr2MsgBuffer.computeIfAbsent(attr, k -> new DataBuffer());
+        // attrlen + utflen + meglen + compress
+        this.datalen += attr.length() + 2 + 4 + 1;
 
         int len = data.remaining();
         try {
@@ -394,9 +390,10 @@ private ByteBuffer defaultBuild(long createtime) {
             out.writeInt(attr2MsgBuffer.size());
 
             if (compress) {
-                for (String attr : attr2MsgBuffer.keySet()) {
+                for (Map.Entry<String, DataBuffer> entry : attr2MsgBuffer.entrySet()) {
+                    String attr = entry.getKey();
+                    DataBuffer data = entry.getValue();
                     out.writeUTF(attr);
-                    DataBuffer data = attr2MsgBuffer.get(attr);
                     if (version.intValue() == Version.v2.intValue()) {
                         out.writeInt(data.cnt);
                     }
@@ -410,9 +407,10 @@ private ByteBuffer defaultBuild(long createtime) {
                     out.write(tmpData, 0, len);
                 }
             } else {
-                for (String attr : attr2MsgBuffer.keySet()) {
+                for (Map.Entry<String, DataBuffer> entry : attr2MsgBuffer.entrySet()) {
+                    String attr = entry.getKey();
+                    DataBuffer data = entry.getValue();
                     out.writeUTF(attr);
-                    DataBuffer data = attr2MsgBuffer.get(attr);
                     if (version.intValue() == Version.v2.intValue()) {
                         out.writeInt(data.cnt);
                     }