[INLONG-8791][TubeMQ] Add log level and log path configuration API to Tubemq-client-go #10040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Tubemq-client-go
2 tasks
TszKitLo40
previously approved these changes
Apr 22, 2024
lvanneo
reviewed
Apr 22, 2024
inlong-tubemq/tubemq-client-twins/tubemq-client-go/log/config.go
Outdated
Show resolved
Hide resolved
inlong-tubemq/tubemq-client-twins/tubemq-client-go/log/config.go
Outdated
Show resolved
Hide resolved
inlong-tubemq/tubemq-client-twins/tubemq-client-go/config/config.go
Outdated
Show resolved
Hide resolved
inlong-tubemq/tubemq-client-twins/tubemq-client-go/config/config.go
Outdated
Show resolved
Hide resolved
lvanneo
approved these changes
Apr 22, 2024
dockerzhang
approved these changes
Apr 22, 2024
gosonzhang
approved these changes
Apr 22, 2024
dockerzhang
pushed a commit
that referenced
this pull request
Apr 23, 2024
… Tubemq-client-go (#10040)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare a Pull Request
Title Example: [INLONG-8791][TubeMQ] Add log level and log path configuration API to Tubemq-client-go
Fixes [Improve][TubeMQ] tubemq-client-go lacks log level configuration API #8791
Motivation
The PR #8793 has a little problem, I solve it.
Modifications
Add validation to SetLogPath and SetLogLeve.
Add log level and log path configuration API.