[INLONG-9925][Sort] Add if statement to solve continuously printing logs #9961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EMsnap
reviewed
Apr 11, 2024
There was a problem hiding this comment.
please use guard code to reduce cyclomatic complexity https://en.wikipedia.org/wiki/Guard_(computer_science)
EMsnap
approved these changes
Apr 11, 2024
aloyszhang
approved these changes
Apr 11, 2024
dockerzhang
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare a Pull Request
[INLONG-9925][Sort] Add if statement to solve continuously printing logs
Fixes [Bug][Sort] Infinite log growth causes insufficient disk space on sort-flink-v1.13(Mysql to Clickhouse) #9925
Motivation
The log keeps printing the same message. This message should be printed when there is update or delete operation for ck and should not appear so many times.And because it continuously write log files, the disk will not has free space soon.
Modifications
I found that the program through JDBC module continuously batch write to clickhouse. But when batch count equals 0, the program still execute batch write command. So the log nonstop print. I add if statement. Only batch count greater than 0, it will execute batch write command.