Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hunspell: tolerate REP rule count mismatches #14079

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

rmuir
Copy link
Member

@rmuir rmuir commented Dec 18, 2024

Similar to support for tolerating PFX/SFX count mismatches, add the ability to tolerate REP count mismatches.

The issue arises in recent updates to LibreOffice mongolian dictionary and is currently failing all PRs that change the analyzers:

https://bugs.documentfoundation.org/show_bug.cgi?id=164366

Similar to support for tolerating PFX/SFX count mismatches, add the
ability to tolerate REP count mismatches.

The issue arises in recent updates to LibreOffice mongolian dictionary
and is currently failing all PRs that change the analyzers:

https://bugs.documentfoundation.org/show_bug.cgi?id=164366
@rmuir rmuir requested review from donnerpeter and dweiss December 18, 2024 05:32
@rmuir rmuir mentioned this pull request Dec 18, 2024
Copy link
Contributor

@donnerpeter donnerpeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, thank you! Update CHANGES.txt?

@rmuir
Copy link
Member Author

rmuir commented Dec 18, 2024

I added a CHANGES. Also the underlying issue is now fixed in the LibreOffice. I will try to chase it down in the bataak repo after brushing up on some mongolian :)

@rmuir rmuir added this to the 10.2.0 milestone Dec 18, 2024
@rmuir rmuir merged commit 0088308 into apache:main Dec 18, 2024
6 checks passed
asfgit pushed a commit that referenced this pull request Dec 18, 2024
Similar to support for tolerating PFX/SFX count mismatches, add the
ability to tolerate REP count mismatches.

The issue arises in recent updates to LibreOffice mongolian dictionary
and is currently failing all PRs that change the analyzers:

https://bugs.documentfoundation.org/show_bug.cgi?id=164366
benchaplin pushed a commit to benchaplin/lucene that referenced this pull request Dec 31, 2024
Similar to support for tolerating PFX/SFX count mismatches, add the
ability to tolerate REP count mismatches.

The issue arises in recent updates to LibreOffice mongolian dictionary
and is currently failing all PRs that change the analyzers:

https://bugs.documentfoundation.org/show_bug.cgi?id=164366
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants