Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing/ltp: Increase Stack Size #2888

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Conversation

lupyuen
Copy link
Member

@lupyuen lupyuen commented Dec 16, 2024

Summary

Inside CI Build risc-v-05: rv-virt:citest fails with a Stack Overflow at ltp_interfaces_pthread_barrierattr_init_2_1:

This PR doubles the Stack Size for testing/ltp (from 4096 bytes to 8192), so that rv-virt:citest completes successfully.

Impact

With this PR, rv-virt:citest will complete successfully.

Testing

We tested rv-virt:citest on Docker:

https://gist.github.com/lupyuen/3688826ed676971536249509ceefe834

sudo docker run \
  -it \
  ghcr.io/apache/nuttx/apache-nuttx-ci-linux:latest \
  /bin/bash
cd
git clone https://github.com/apache/nuttx
git clone https://github.com/lupyuen2/wip-nuttx-apps --branch ltp-stack apps
pushd nuttx ; echo NuttX Source: https://github.com/apache/nuttx/tree/$(git rev-parse HEAD) ; popd
pushd apps  ; echo NuttX Apps: https://github.com/apache/nuttx-apps/tree/$(git rev-parse HEAD) ; popd
cd nuttx/tools/ci
./cibuild.sh -c -A -N -R testlist/risc-v-05.dat 

NuttX Source: https://github.com/apache/nuttx/tree/0913fa4b7343686c76affdfa177aed73917963ad
NuttX Apps: https://github.com/apache/nuttx-apps/tree/887729409fb64d4c54b18d247e37029b78d90107
Configuration/Tool: rv-virt/citest
test_open_posix/test_openposix_.py::test_ltp_interfaces_pthread_barrierattr_init_2_1 PASSED                  [ 17%]
test_os/test_os.py::test_ostest PASSED                                                                       [ 99%]
=========================== 990 passed, 11 skipped, 67 deselected in 1849.40s (0:30:49) ============================

Inside CI Build risc-v-05: `rv-virt:citest` fails with a Stack Overflow at ltp_interfaces_pthread_barrierattr_init_2_1:
- apache/nuttx#15170

This PR doubles the Stack Size for `testing/ltp` (from 4096 bytes to 8192), so that `rv-virt:citest` completes successfully.
Copy link

@cederom cederom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @lupyuen nice catch! :-)

@xiaoxiang781216 xiaoxiang781216 merged commit 9c5568c into apache:master Dec 16, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] rv-virt:citest fails with Load Access Fault at ltp_interfaces_pthread_barrierattr_init_2_1 (risc-v-05)
3 participants