Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake[enhance]:builtin register support NONE srcs target #2934

Merged
merged 1 commit into from
Jan 9, 2025
Merged

cmake[enhance]:builtin register support NONE srcs target #2934

merged 1 commit into from
Jan 9, 2025

Conversation

xuxin930
Copy link
Contributor

@xuxin930 xuxin930 commented Jan 9, 2025

Summary

Support add_application to register without compiling,
used in scenarios where redefining the main symbol is not required

Impact

enhancement

Testing

CI test build

@xuxin930 xuxin930 mentioned this pull request Jan 9, 2025
Merged
cederom
cederom approved these changes Jan 9, 2025
View reviewed changes
Copy link

@cederom cederom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @xuxin930 :-)

@xiaoxiang781216 xiaoxiang781216 merged commit 4e854cf into apache:master Jan 9, 2025
64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@no1wudi no1wudi no1wudi approved these changes

@cederom cederom cederom approved these changes

Assignees
No one assigned
Labels
Area: Binfmt Size: XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xuxin930 @cederom @no1wudi @xiaoxiang781216