HDDS-12095. Include AWS request ID in S3G audit logs

[peterxcli]

What changes were proposed in this pull request?

We have a RequestIdentifier object that is used to generate the request ID and amz ID to the S3 response.
It will be useful to include this S3G audit so that it's easier to for the administrators to locate problematic request from the audit logs when only request ID is provided.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-12095

How was this patch tested?

unit tests

[adoroszlai]

Thanks @peterxcli for the patch.

S3 acceptance tests are failing due to:

UnsupportedOperationException
	at java.base/java.util.AbstractMap.put(AbstractMap.java:213)
	at org.apache.hadoop.ozone.s3.endpoint.EndpointBase.auditMessageBaseBuilder(EndpointBase.java:451)
	at org.apache.hadoop.ozone.s3.endpoint.EndpointBase.buildAuditMessageForSuccess(EndpointBase.java:471)
	at org.apache.hadoop.ozone.s3.endpoint.RootEndpoint.get(RootEndpoint.java:87)

https://github.com/peterxcli/ozone/actions/runs/12866814923

Also, integration tests are failing with:

Error:  org.apache.hadoop.ozone.s3.endpoint.TestObjectTaggingPut.testPutInvalidObjectTagging  Time elapsed: 1.847 s  <<< ERROR!
java.lang.NullPointerException: Cannot invoke "org.apache.hadoop.ozone.s3.RequestIdentifier.getRequestId()" because "this.requestIdentifier" is null
	at org.apache.hadoop.ozone.s3.endpoint.EndpointBase.auditMessageBaseBuilder(EndpointBase.java:451)
	at org.apache.hadoop.ozone.s3.endpoint.EndpointBase.buildAuditMessageForSuccess(EndpointBase.java:478)
	at org.apache.hadoop.ozone.s3.endpoint.ObjectEndpoint.put(ObjectEndpoint.java:397)
	at org.apache.hadoop.ozone.s3.endpoint.TestObjectTaggingPut.setup(TestObjectTaggingPut.java:87)

https://github.com/peterxcli/ozone/actions/runs/12866814923/job/35870718714#step:6:2861

[peterxcli]

@adoroszlai Thanks for reminding the error tests, just fixed them, PTAL. Thanks!

[adoroszlai]

Thanks @peterxcli for fixing the tests. There is one more: TestMultipartObjectGet.

[peterxcli]

https://github.com/peterxcli/ozone/actions/runs/12883333075
CI pass

[peterxcli]

Hi @adoroszlai, I’ve just started contributing to this project, and I had a quick question. Do I need to attach the CI run link to each PR, or is there a more convenient way to locate the CI runs without navigating to my fork and finding the action through the latest commit name?

[ivandika3]

@peterxcli Thanks for picking this up. LGTM +1.

[adoroszlai]

I’ve just started contributing to this project

Thank you, and welcome to Ozone!

Do I need to attach the CI run link to each PR,

When opening new PR:

• Please wait for clean CI run in fork before opening PR. This lets you tweak the change until it passes tests.
• Please provide link in the PR description to the successful CI run.
• Once PR is opened like that, if new commit is pushed e.g. for review, there is no need to provide further links to runs from fork.

or is there a more convenient way to locate the CI runs without navigating to my fork and finding the action through the latest commit name?

This is a direct link to CI runs in your fork:
https://github.com/peterxcli/ozone/actions/workflows/post-commit.yml

[adoroszlai]

Thanks @peterxcli for the patch, @ivandika3 for the review.