Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update example in shredding spec #478

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update example in shredding spec #478

wants to merge 1 commit into from

Conversation

aihuaxu
Copy link
Contributor

@aihuaxu aihuaxu commented Jan 10, 2025 •
edited
Loading

Rationale for this change

What changes are included in this PR?

Seems the example included in shredding spec is not correct. 123 in row 3 and 4 can be shredded. Correct them to avoid confusion.

Do these changes have PoC implementations?

Closes #477

@aihuaxu
Copy link
Contributor Author

aihuaxu commented Jan 10, 2025 •
edited
Loading

cc @gene-db and @cashmand. We will remove this in #461, but want to make sure my understanding is correct.

cashmand
cashmand approved these changes Jan 10, 2025
View reviewed changes
Copy link

@cashmand cashmand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, I think the old example was mistaken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cashmand cashmand cashmand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MINOR: correct the example in shredding specification
2 participants
@aihuaxu @cashmand