Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

push down method refactoring. #172

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

push down method refactoring. #172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions fontbox/src/main/java/org/apache/fontbox/ttf/OTFParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,6 @@ OpenTypeFont newFont(TTFDataStream raf)
return new OpenTypeFont(raf);
}

@Override
protected TTFTable readTable(String tag)
{
// todo: this is a stub, a full implementation is needed
Expand All @@ -77,7 +76,7 @@ protected TTFTable readTable(String tag)
case CFFTable.TAG:
return new CFFTable();
default:
return super.readTable(tag);
return new TTFTable();
}
}

Expand Down
8 changes: 1 addition & 7 deletions fontbox/src/main/java/org/apache/fontbox/ttf/TTFParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,7 @@ private TTFTable readTableDirectory(TTFDataStream raf) throws IOException
table = new GlyphSubstitutionTable();
break;
default:
table = readTable(tag);
table = new TTFTable();
break;
}
table.setTag(tag);
Expand All @@ -305,10 +305,4 @@ private TTFTable readTableDirectory(TTFDataStream raf) throws IOException

return table;
}

protected TTFTable readTable(String tag)
{
// unknown table type but read it anyway.
return new TTFTable();
}
}