-
Notifications
You must be signed in to change notification settings - Fork 794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce GoogleDrive Fetcher for tika-pipes #2077
base: main
Are you sure you want to change the base?
Conversation
@tballison Cleaned up version of #2074 now that I sorted out what's going on with the tika-grpc-3x-features branch (it will require cleanup) |
The pom.xml has several properties that are not used, e.g. kiota, wiremock, nimbus, etc. You probably copied them from another (older) pom.xml. I think you only need the first one. |
Thanks, I was indeed copying and did not review the pom.xml too deeply. Cleaned up: 880a2ea |
There are still 3 that you don't need, one that isn't used and two that are defined in the parent. |
880a2ea
to
0884a58
Compare
I think I got them in the final push. Is there a way to identify these during build? I didn't notice it in the output |
I got these by looking at the source code. This is just me, I like smaller pom.xml files that are easier to understand and maintain. Is it possible for you to create some sort of unit test, or is this impossible because one would need some google drive access? |
Thanks for the commits and notes. I'm not too familiar with the project and am entering through tika-pipes and its fetcher requirements, so I appreciate your patience.
I imagine we could mock the response from Google Drive, so at least we test happy/sad paths. Let me have a try at it. |
So I was able to fix the google driver fetcher pom.xml, but now the pipes gRPC server is failing with dependency convergence errors. 😬 I'll try to fix that too. |
I managed to do a complete build locally, mostly by moving the dependencyManagement stuff I introduced to the parent. I'll do another test locally and then add this here. |
@THausherr Looks like you got this building. Are you happy with your changes? If so I will squash them into a single commit. |
Yes! |
@THausherr Great. Btw, since these changes, I am unable to build tika-pipes (which is what I am building, not the whole project). It looks like the pom.xml that was previously expected no longer is applicable. Are you able to help? Here's the error:
And here's my build script:
|
This allows the fetching of items using files.get from Google Drive
f5e9dbe
to
c8d3ea7
Compare
I didn't touch tika-grpc/pom.xml at all. Your script has "tika-pipes/tika-grpc" however "tika-grpc" is at the top level. |
@THausherr Thanks, I sorted that out. Looks like my paths are based on tika-grpc-3x-features branch paths. |
I am porting this into https://github.com/nddipiazza/tika-pipes |
This introduces a Google Drive fetcher into the tika-pipes project