Included optional run for createRules script. #125
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thank you for sharing this body of work with the world!
Issue
I experienced some difficulties in auto-generating the
.rules
file for a specific bank with thepreprocess
script, as that script requires the.rules
file to already exist. And I experienced some difficulties using your software to convert the2-preprocess
files into3-journal
files with theconstruct
script, as that is assumed to do that itself.Solution
So I modified
CSVImport.hs
to run acreateRules
script if it exists prior to running thepreprocess
script.Limitations
The function call with the call towards the
createRules
script is added under thepreprocessIfNeeded
function, which makes thepreprocessIfNeeded
function do 2 things instead of one. So it would be better to refactor that, however I never used Haskal and had limited time allocated to this solution, so I hope you feel free to reject the PR or specify exact requirements for acceptance if you would like the functionality to be included.