Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Included optional run for createRules script. #125

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

a-t-0
Copy link

@a-t-0 a-t-0 commented Dec 2, 2024

Hi, thank you for sharing this body of work with the world!

Issue

I experienced some difficulties in auto-generating the .rules file for a specific bank with the preprocess script, as that script requires the .rules file to already exist. And I experienced some difficulties using your software to convert the 2-preprocess files into 3-journal files with the construct script, as that is assumed to do that itself.

Solution

So I modified CSVImport.hs to run a createRules script if it exists prior to running the preprocess script.

Limitations

The function call with the call towards the createRules script is added under the preprocessIfNeeded function, which makes the preprocessIfNeeded function do 2 things instead of one. So it would be better to refactor that, however I never used Haskal and had limited time allocated to this solution, so I hope you feel free to reject the PR or specify exact requirements for acceptance if you would like the functionality to be included.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant