Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to disable code decompilation #61

Merged
merged 3 commits into from
Nov 22, 2023

Conversation

threethan
Copy link
Contributor

Old Behavior:

  • Dex-to-smali decompilation is always enabled
  • Exploring applications with a lot of code is always slow

New Behavior:

  • Dex-to-smali decompilation is enabled by default, but may be disabled by the user
  • Exploring applications with a lot of code is much faster if decompilation is disabled

Decompilation of dex to smali is a great feature, but accounts for most of the time it takes to open most apk files.

This PR adds an option to the settings which allows you to disable decompilation of dex files. Skipping this works fine, as AEE already uses unmodified dex files for rebuilding if no smali changes were made.

Caveats:

  • Cached applications will stay with the setting from when the cache was made, leading to the following possiblity:
    1. User disables decompilation
    2. User opens foo.apk
    3. User closes foo.apk, and it is automatically cached
    4. User enables decompilation
    5. User opens foo.apk
    6. foo.apk is loaded from cache and not decompiled
  • A few strings have been added, which are only in English

Includes the same AGP update as my other commit.
Includes a fix for a minor issue where "textTwo" and "icon" could be hidden when a setting was changed.

@apk-editor
Copy link
Owner

@threethan
Thanks for this PR, which is already in my to-do list. I was postponed it becasue I have to find a way to decompile dex files independantly (if the user decided to do so). Right now, the original APK file is requried. I'll merge it anyway, with some cosmetic modifications soon.

@threethan
Copy link
Contributor Author

That would definitely be the best option, but this was easier to implement. Glad to help with your backlog.

@apk-editor apk-editor merged commit c908b03 into apk-editor:master Nov 22, 2023
1 check passed
apk-editor added a commit that referenced this pull request Nov 22, 2023
…istent with the rest of the app

Related to PR #61

Signed-off-by: apk-editor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants