feature: Adds support for GraphQL over HTTP media type #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Docs Preview ReadyNo new or changed pages found. |
✅ Deploy Preview for apollo-ios-docc canceled.
|
✅ Deploy Preview for eclectic-pie-88a2ba ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Done. |
calvincestari
commented
Dec 17, 2024
|
|
||
| // This test is odd because you might assume it would fail but there is no content-type checking on standard | ||
| // GraphQL response parsing. So this test is here to ensure that existing behaviour does not change. | ||
| func test__response__givenUnknownContentType_shouldNotFail() throws { |
There was a problem hiding this comment.
I've added tests to keep the existing behaviour of standard GraphQL response parsing including this odd one.
AnthonyMDev
reviewed
Dec 19, 2024
calvincestari
force-pushed
the
feature/graphql-media-type
branch
from
78085ef to
179d004
Compare
|
@AnthonyMDev - this PR is ready for another review, I've addressed the previous comment. |
AnthonyMDev
approved these changes
Jan 9, 2025
BobaFetters
pushed a commit
that referenced
this pull request
Jan 9, 2025
BobaFetters
pushed a commit
to apollographql/apollo-ios
that referenced
this pull request
Jan 9, 2025
BobaFetters
pushed a commit
that referenced
this pull request
Jan 9, 2025
ee597100 feature: Adds support for GraphQL over HTTP media type (#558) git-subtree-dir: apollo-ios git-subtree-split: ee59710005066e0f9516730a64eb800d8486a74a
BobaFetters
pushed a commit
that referenced
this pull request
Jan 9, 2025
…HTTP media type git-subtree-dir: apollo-ios git-subtree-mainline: b7ef8e6 git-subtree-split: ee59710005066e0f9516730a64eb800d8486a74a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes apollographql/apollo-ios#3485.
application/json. Instead it simply attempts to deserialize anything as if it is JSON. It's only in the multipart parsers that we do a content type check for the chunks. @AnthonyMDev - this hasn't been an issue for now but do you think we should add this check? I'm inclined to leave the standard parser as it is.