Support jpkl executable for Windows #872
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bioball
changed the title
bioball
force-pushed
the
jpkl-for-windows
branch
2 times, most recently
from
61e8245 to
f2a5650
Compare
|
Heads up: this needs an update too https://github.com/apple/pkl/blob/main/pkl-cli/pkl-cli.gradle.kts#L361-L362 (for JVM versions as well?) Also typo in PR title: |
This updates the script used to start the executable to support Windows as well. For Windows support, the executable needs to be named `jpkl.bat`.
bioball
changed the title
bioball
force-pushed
the
jpkl-for-windows
branch
from
138830e to
0bbf2b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the script used to start the executable to support Windows as well.
For Windows support, the executable needs to be named
jpkl.bat.No unit tests here, but this is tested on macOS directly, and on Windows in my Parallels instance.
This follows a technique shown by this blog post: https://mill-build.org/blog/5-executable-jars.html. Thanks, @lihaoyi!