Migrate to GitHub Actions #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnro
force-pushed
the
adopt_github_actions
branch
from
fddf7d6 to
0411de5
Compare
FranzBusch
approved these changes
Oct 31, 2024
.github/workflows/pull_request.yml
Outdated
Comment on lines
28
to
31
| swift-6-language-mode: | ||
| name: Swift 6 Language Mode | ||
| uses: apple/swift-nio/.github/workflows/swift_6_language_mode.yml@main | ||
| if: false # Disabled for now. |
There was a problem hiding this comment.
I think we have been inconsistent with this but IIRC the latest we decided is to not add this to PRs at all. Maybe we should do this here as well.
Migrate CI to use GitHub Actions. Motivation: To migrate to GitHub actions and centralised infrastructure. Modifications: Changes of note: * Adopt swift-format using rules from SwiftNIO * Remove scripts and docker files which are no longer needed Result: Feature parity with old CI.
rnro
force-pushed
the
adopt_github_actions
branch
from
0411de5 to
03ffcb5
Compare
|
LGTM, i switched all the branch protection rules. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate CI to use GitHub Actions.
Motivation:
To migrate to GitHub actions and centralised infrastructure.
Modifications:
Changes of note:
Result:
Feature parity with old CI.