Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Swift 6 mode on the plugin examples to ensure generated code compiles in this mode #1740

Merged
merged 2 commits into from
Jan 7, 2025
Merged

Use Swift 6 mode on the plugin examples to ensure generated code compiles in this mode #1740

merged 2 commits into from
Jan 7, 2025
+123 −26

Conversation

thomasvl
Copy link
Collaborator

@thomasvl thomasvl commented Jan 6, 2025

No description provided.

@thomasvl
Make the message a linked list so it uses _Storage also.
19376ce
@thomasvl
Test the plugin in Swift 6 mode.
cbc7c08 
Split the current `Package.swift` into versions files to remove conditionals
and support 5.8, 5.9, and 6.0 with 6 ensuring the language mode will be 6.
@thomasvl
Copy link
Collaborator Author

thomasvl commented Jan 6, 2025

Tried having only the 5.8 file that was like the old file, but 5.9 fails (https://github.com/apple/swift-protobuf/actions/runs/12640958090), I guess SwiftPM won't use a versioned file that is ≤ the current version still. 😦

@thomasvl thomasvl requested a review from Lukasa January 6, 2025 22:29
@thomasvl thomasvl changed the title Test swift6 mode Use Swift 6 mode on the plugin examples to ensure generated code compiles in this mode Jan 6, 2025
@FranzBusch
Copy link
Member

Tried having only the 5.8 file that was like the old file, but 5.9 fails (https://github.com/apple/swift-protobuf/actions/runs/12640958090), I guess SwiftPM won't use a versioned file that is ≤ the current version still. 😦

Yes you always have to specify one per version.

@thomasvl thomasvl marked this pull request as ready for review January 7, 2025 14:18
@thomasvl thomasvl merged commit 8d33562 into apple:main Jan 7, 2025
12 checks passed
@thomasvl thomasvl deleted the test_swift6_mode branch January 7, 2025 14:18
@thomasvl
Copy link
Collaborator Author

thomasvl commented Jan 7, 2025

Tried having only the 5.8 file that was like the old file, but 5.9 fails (https://github.com/apple/swift-protobuf/actions/runs/12640958090), I guess SwiftPM won't use a versioned file that is ≤ the current version still. 😦

Yes you always have to specify one per version.

I guess 5.10 does support falling back to older versions, I didn't have to provide a file specific to that version and things worked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FranzBusch FranzBusch FranzBusch approved these changes

@Lukasa Lukasa Awaiting requested review from Lukasa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomasvl @FranzBusch