Support network based api keys #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xmaayan
requested review from
kaw2k,
hardsetting and
kent-white
as code owners
0xmaayan
force-pushed
the
multiple_api_keys
branch
2 times, most recently
from
5b74880 to
44810f4
Compare
kent-white
approved these changes
Dec 3, 2024
hardsetting
approved these changes
Dec 3, 2024
| @@ -108,6 +116,17 @@ export const isAptosNetwork = ( | |||
| return NetworkToNodeAPI[networkInfo.name] !== undefined; | |||
| }; | |||
|
|
|||
| export const isAptosLiveNetwork = (networkInfo: Network): boolean => { | |||
| if (!networkInfo) { | |||
There was a problem hiding this comment.
did you encounter this case?
There was a problem hiding this comment.
oops, copy-past, removed
0xmaayan
force-pushed
the
multiple_api_keys
branch
from
44810f4 to
50d9acf
Compare
0xmaayan
force-pushed
the
multiple_api_keys
branch
from
50d9acf to
ef11416
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently added API Key support to the adapter, but an API key is a network based, so supporting only 1 api key doesnt make sense when the user connects their wallet to different networks.
This PR adds support for a network based API Key so the adapter uses the correct API Key based on the network the wallet is connected to