Upload 5 source maps artifacts in parallel for better performance

arabold · Jun 22, 2022 · 2e0dcda · 2e0dcda
1 parent 2ae2dd2
commit 2e0dcda
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 6 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -51,6 +51,7 @@
     "serverless-sentry-lib": "2.x.x"
   },
   "dependencies": {
+    "@supercharge/promise-pool": "^2.3.0",
     "adm-zip": "^0.5.9",
     "semver": "^7.3.2",
     "superagent": "^7.1.6",

diff --git a/src/index.ts b/src/index.ts
@@ -1,5 +1,6 @@
 import * as path from "path";
 
+import { PromisePool } from "@supercharge/promise-pool";
 import * as AdmZip from "adm-zip";
 import * as SemVer from "semver";
 import Serverless from "serverless";
@@ -443,7 +444,7 @@ export class SentryPlugin implements Plugin {
       return;
     }
 
-    this.serverless.cli.log("Uploading sourcemaps to sentry", "sentry");
+    this.serverless.cli.log("Uploading source maps to Sentry", "sentry");
 
     const artifacts = new Set(
       this.serverless.service
@@ -464,11 +465,10 @@ export class SentryPlugin implements Plugin {
       });
     });
 
-    // Upload artifacts one after the other
-    await results.reduce(
-      (previousPromise, nextArtifact) => previousPromise.then(() => nextArtifact()),
-      Promise.resolve(),
-    );
+    // Upload artifacts
+    await PromisePool.withConcurrency(5)
+      .for(results)
+      .process(async (nextArtifact) => await nextArtifact());
   }
 
   async _uploadSourceMap(entry: AdmZip.IZipEntry, params: ApiParameters): Promise<void> {