Lightening the DAO Factory

aragon · May 31, 2024 · bb8b3eb · bb8b3eb
1 parent d5a3d2c
commit bb8b3eb
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/script/Deploy.s.sol b/script/Deploy.s.sol
@@ -33,6 +33,7 @@ contract Deploy is Script {
         }
 
         TaikoDaoFactory factory = new TaikoDaoFactory(settings);
+        factory.deployOnce();
         TaikoDaoFactory.Deployment memory deployment = factory.getDeployment();
 
         vm.stopBroadcast();

diff --git a/src/factory/TaikoDaoFactory.sol b/src/factory/TaikoDaoFactory.sol
@@ -65,18 +65,21 @@ contract TaikoDaoFactory {
         PublicKeyRegistry publicKeyRegistry;
     }
 
+    /// @notice Thrown when attempting to call deployOnce() when the DAO is already deployed.
+    error AlreadyDeployed();
+
     DeploymentSettings settings;
     Deployment deployment;
 
     /// @notice Initializes the factory and performs the full deployment. Values become read-only after that.
     /// @param _settings The settings of the one-time deployment.
     constructor(DeploymentSettings memory _settings) {
         settings = _settings;
-
-        deploy();
     }
 
-    function deploy() internal {
+    function deployOnce() public {
+        if (address(deployment.dao) != address(0)) revert AlreadyDeployed();
+
         IPluginSetup.PreparedSetupData memory preparedMultisigSetupData;
         IPluginSetup.PreparedSetupData memory preparedEmergencyMultisigSetupData;
         IPluginSetup.PreparedSetupData memory preparedOptimisticSetupData;