Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip-changelog] Bump to go 1.23 #2811

Merged
merged 7 commits into from
Jan 13, 2025
Merged

[skip-changelog] Bump to go 1.23 #2811

merged 7 commits into from
Jan 13, 2025

Conversation

alessio-perugini
Copy link
Contributor

@alessio-perugini alessio-perugini commented Jan 13, 2025

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Bump to go 1.23, and update all related files/tools.

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change, and is titled accordingly?

Other information

non-constant format string in call. We were calling some format
function, but we were always passing a "static" string.
redefines-builtin-id: redefinition of the built-in function max (revive)
@alessio-perugini alessio-perugini self-assigned this Jan 13, 2025
Copy link
Contributor

github-actions bot commented Jan 13, 2025

The latest Buf updates on your PR. Results from workflow Check Protocol Buffers / check (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedJan 13, 2025, 3:46 PM

G115: integer overflow conversion int -> uint (gosec)
@cmaglie cmaglie added type: enhancement Proposed improvement topic: infrastructure Related to project infrastructure topic: code Related to content of the project itself labels Jan 13, 2025
Copy link
Member

@cmaglie cmaglie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 56.66667% with 13 lines in your changes missing coverage. Please review.

Project coverage is 67.67%. Comparing base (24799f3) to head (e867bf8).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
internal/arduino/builder/sketch.go 41.17% 6 Missing and 4 partials ⚠️
commands/instances.go 0.00% 1 Missing ⚠️
...ino/libraries/librariesmanager/librariesmanager.go 50.00% 1 Missing ⚠️
internal/cli/lib/examples.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2811      +/-   ##
==========================================
+ Coverage   67.63%   67.67%   +0.04%     
==========================================
  Files         238      239       +1     
  Lines       22392    22408      +16     
==========================================
+ Hits        15144    15165      +21     
+ Misses       6060     6049      -11     
- Partials     1188     1194       +6     
Flag Coverage Δ
unit 67.67% <56.66%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alessio-perugini alessio-perugini marked this pull request as ready for review January 13, 2025 16:04
@alessio-perugini alessio-perugini merged commit 34e79e1 into master Jan 13, 2025
208 checks passed
@alessio-perugini alessio-perugini deleted the bump-to-go-1-23 branch January 13, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants