Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I2S: AAC support for web radio #22787

Merged
merged 2 commits into from
Jan 8, 2025
Merged

Conversation

Staars
Copy link
Contributor

@Staars Staars commented Jan 8, 2025

Description:

This allows to build a binary with support for AAC web radio streams with flag: USE_I2S_AAC (or USE_I2S_ALL if binary size does not matter)
Increases binary size by 75596 bytes in my test build.

Add optional decoder type to command i2swr in the form of:
i2swr<int:type> <string: url>
types:
0 - AAC
1 - MP3 (makes it backwards compatible as i2swr url == i2swr1 url)

Small refactoring and renaming in the web page.

Checklist:

  • The pull request is done against the latest development branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works with Tasmota core ESP8266 V.2.7.8
  • The code change is tested and works with Tasmota core ESP32 V.3.1.0.241206
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

@s-hadinger
Copy link
Collaborator

As long as it's not included by default, I'm fine with this.
Congrats!

@Staars
Copy link
Contributor Author

Staars commented Jan 8, 2025

Yes, it is not enabled by default.
Current build environments with fine grained control for the audio build flags (single flags) will not pick this up.

The shortcut USE_I2S_ALL will include it as intended.

@probonopd
Copy link

Tested on esp32-s2 with PSRAM:

i2swr0 https://liveradio.swr.de/sw890cl/swr1bw/play.aac

Works great 👍 Thanks @Staars

@Jason2866 Jason2866 merged commit b73f50b into arendst:development Jan 8, 2025
59 checks passed
@Staars Staars deleted the i2s_aac_decoder branch January 9, 2025 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants