fix: checking for errors when converting GitHub App and Installation IDs

Signed-off-by: Dustin Lactin <[email protected]>
argoproj-labs · Dec 7, 2023 · 674a9fe · 674a9fe
1 parent 6ea67ef
commit 674a9fe
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/pkg/argocd/gitcreds.go b/pkg/argocd/gitcreds.go
@@ -76,8 +76,14 @@ func getCredsFromSecret(wbc *WriteBackConfig, credentialsSecret string, kubeClie
 				return nil, fmt.Errorf("invalid secret %s: does not contain field githubAppPrivateKey", credentialsSecret)
 			}
 			// converting byte array to string and ultimately int64 for NewGitHubAppCreds
-			intGithubAppID, _ := strconv.ParseInt(string(githubAppID), 10, 64)
+			intGithubAppID, err := strconv.ParseInt(string(githubAppID), 10, 64)
+			if err != nil {
+				return nil, err
+			}
 			intGithubAppInstallationID, _ := strconv.ParseInt(string(githubAppInstallationID), 10, 64)
+			if err != nil {
+				return nil, err
+			}
 			return git.NewGitHubAppCreds(intGithubAppID, intGithubAppInstallationID, string(githubAppPrivateKey), "", "", "", "", true), nil
 		} else if username, ok = credentials["username"]; ok {
 			if password, ok = credentials["password"]; !ok {