-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: #896 App of apps being overwritten by image-updater #918
Conversation
Signed-off-by: Cheng Fang <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #918 +/- ##
==========================================
- Coverage 74.70% 74.64% -0.06%
==========================================
Files 31 31
Lines 3922 3913 -9
==========================================
- Hits 2930 2921 -9
Misses 856 856
Partials 136 136 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the quick fix!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We should put out a 0.15.1 with this fix asap. |
thanks @jannfis . I'll cherry-pick bug fixes to release-0.15 branch and work on the v0.15.1 (#920) https://issues.redhat.com/browse/GITOPS-5813 |
…argoproj-labs#918) Signed-off-by: Cheng Fang <[email protected]>
Fixes #896