-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: correct formatting issues #983
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #983 +/- ##
==========================================
- Coverage 71.99% 63.42% -8.57%
==========================================
Files 24 15 -9
Lines 3642 2212 -1430
==========================================
- Hits 2622 1403 -1219
+ Misses 880 723 -157
+ Partials 140 86 -54 ☔ View full report in Codecov by Sentry. |
@kj800x thanks for the fix. Can you fix the DCO error by signing off the commit? After that, it should be good to go. |
Thanks for taking a look! I noticed the DCO check failed and looked into it, but I'm not familiar with what 'signing off' a commit entails or its significance. Since this isn't mentioned in the README or contributing documentation, would you mind clarifying? I'm hesitant to sign my name to something without knowing what that means. It might also be helpful to add guidance on this to the contributing docs for future contributors. |
In this project we use sign-off as a way for PR submitters to certify their consent to license and code ownership, which is a common practice among open source projects, though there are some other projects that do not require it. For a formal explanation you may want to check git-commit man page or other formal docs. |
I've updated the development guide to include the DCO signoff requirement. Thanks for bringing that up. Do you have any other concerns or questions regarding this PR? |
Thanks for updating that. I'm happy to update the commits with that in mind. From what I'm seeing in the man page you suggest, the meaning of a signoff depends on the project to which you're committing. It lists http://developercertificate.org as one example of what that may mean, but ultimately leaves it project dependent. I don't think it's reasonable for contributors to assume that it means DCO (absent other documentation), nor does this seem to be a common practice in my personal experience.
All that said, I think the updates that you've made to your documentation have now made the meaning for your project clear. Thank you! I'll be force pushing updated commits momentarily! |
Signed-off-by: Kevin Johnson <[email protected]>
Signed-off-by: Kevin Johnson <[email protected]>
I'm not entirely sure of the correct syntax or the process for testing these docs locally (just doing a drive-by commit on GitHub). I noticed that some of the Warning blocks in the docs had broken formatting. This PR should fix that.
Before