fix: Use correct type union in CRD spec for Quantity fields #4013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix sets the expected types based on the current K8S upstream OpenAPI v3 types: https://github.com/kubernetes/kubernetes/blob/release-1.32/api/openapi-spec/v3/api__v1_openapi.json#L8637 Signed-off-by: Stephen Heckler <[email protected]>
heckler1
force-pushed
the
heckler1/fixQuantityType
branch
from
e7fa895 to
6d74059
Compare
heckler1
changed the title
|
Published E2E Test Results0 tests 0 ✅ 0s ⏱️ Results for commit cc597cd. |
Published Unit Test Results2 293 tests 2 293 ✅ 2m 59s ⏱️ Results for commit cc597cd. |
|
Hmm, this doesn't seem to pass e2e, I'll iterate locally, sorry for the noise! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix sets the expected types based on the current K8S upstream OpenAPI v3 types: https://github.com/kubernetes/kubernetes/blob/release-1.32/api/openapi-spec/v3/api__v1_openapi.json#L8637