Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong background color for last symbol #106

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jgerken
Copy link

@jgerken jgerken commented Apr 4, 2017

Bash supports setting the background color to default background color since version 2.53 (http://pueblo.sourceforge.net/doc/manual/ansi_color_codes.html). This fix has a glitch when the macOS X Terminal.app is used (my version is 2.7.2 (388.1) on macOS Sierra 10.12.4): the background color is correct but Terminal uses a brighter color for the foreground than is should.

@krayon
Copy link

krayon commented Apr 12, 2017

I believe the suggestion I made in Issue #49 to just reset then set colour again is the easiest. It doesn't have any version requirement then.

@jgerken
Copy link
Author

jgerken commented Apr 13, 2017

I checked the version requirement again and have to admit that I read the website I cited wrong. The version given in the document is not the BASH version but the version of their software. I tried to figure out when the default background color (value 49) was standardized and found the Standard ECMA-48 Control Functions for Coded Character Sets, 5th edition (June 1991) which already lists 49 default background color (implementation-defined) (page 62 in the PDF). Thus, setting the background color to the standard background color is already part of the standard since 1991. Therefore, I assume that it is supported by every terminal used today and can be used any concern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants