Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Vds prefix to Vue Components to avoid conflict with standard HTML elements #178

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ludij
Copy link

@ludij ludij commented Apr 11, 2019

Problem:
when using Vue Design System on a static website, there's a conflict between components which have the same name as a standard HTML element (i.e. <Button> and <button>). This results in the standard HTML element being displayed instead of the Vue component.

Solution:
renaming all Vue components by adding a prefix 'Vds', i.e. 'VdsButton' for a button component.

Extra:
in the examples (here and here) the component names should be changed as well. In the static website example, it would be best to use kebab-case for the components, i.e. <vds-nav-bar> instead of <NavBar> and to add a recommendation for using kebab-case in the README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant