Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/fix ie11 buble #180

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lukenofurther
Copy link

Fixes issue #158, as suggested in this vue-styleguidist issue.

Note that the first commit simply commits changes that appear in package-lock.json after running the initial npm install.

Luke Lewis added 2 commits April 11, 2019 15:47
- Adds package-lock changes appearing on first npm install
- Adds ES6 package dependencies to babel webpack include
- Adds browser targets to buble and babel options
@nplowman
Copy link

Adding a note for anyone else who encountered this:

I found that I had to include acorn-jsx like this:
resolve("node_modules/acorn-jsx"),
rather than like this:
resolve("node_modules/buble/node_modules/acorn-jsx"),
for it to work.

I think whether or not you have the nested node_module paths might depend on the version of node you are using.

@arapd
Copy link

arapd commented Oct 4, 2019

This issue is essential to work with IE11. Is there a plan to merge this PR and release a version soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants