Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_designs): Add platform match criteria for network_ports #4798

Merged
merged 23 commits into from
Jan 22, 2025

Conversation

kpbush30
Copy link
Contributor

@kpbush30 kpbush30 commented Dec 9, 2024

Change Summary

Add platform match criteria for network_ports

Related Issue(s)

Fixes #4786

Component(s) name

arista.avd.eos_designs

Proposed changes

Add platform key to match to filter devices for network_ports

How to test

Run molecule scenario for eos_designs_uni_tests for NETWORK_PORTS_TESTS

molecule converge -s eos_designs_unit_tests -- --limit NETWORK_PORTS_TESTS

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

github-actions bot commented Dec 9, 2024

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4798
# Activate the virtual environment
source test-avd-pr-4798/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/kpbush30/avd.git@network_ports_4786#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/kpbush30/avd.git#/ansible_collections/arista/avd/,network_ports_4786 --force
# Optional: Install AVD examples
cd test-avd-pr-4798
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Dec 9, 2024
@kpbush30 kpbush30 marked this pull request as ready for review December 9, 2024 16:56
@kpbush30 kpbush30 requested review from a team as code owners December 9, 2024 16:56
@github-actions github-actions bot added the state: conflict PR with conflict label Dec 20, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the state: conflict PR with conflict label Jan 17, 2025
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment and good to go

thanks @kpbush30 for this PR!

@gmuloc gmuloc merged commit e57a458 into aristanetworks:devel Jan 22, 2025
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Feat(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat(eos_designs): Add platform match criteria for network_ports
4 participants