-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_designs): Add platform match criteria for network_ports #4798
Conversation
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4798
# Activate the virtual environment
source test-avd-pr-4798/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/kpbush30/avd.git@network_ports_4786#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/kpbush30/avd.git#/ansible_collections/arista/avd/,network_ports_4786 --force
# Optional: Install AVD examples
cd test-avd-pr-4798
ansible-playbook arista.avd.install_examples |
for more information, see https://pre-commit.ci
...ions/arista/avd/molecule/eos_designs_unit_tests/inventory/group_vars/NETWORK_PORTS_TESTS.yml
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/schema/schema_fragments/network_ports.schema.yml
Outdated
Show resolved
Hide resolved
...ions/arista/avd/molecule/eos_designs_unit_tests/inventory/group_vars/NETWORK_PORTS_TESTS.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/schema/schema_fragments/network_ports.schema.yml
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/structured_config/connected_endpoints/utils.py
Show resolved
Hide resolved
...ions/arista/avd/molecule/eos_designs_unit_tests/inventory/group_vars/NETWORK_PORTS_TESTS.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/schema/schema_fragments/network_ports.schema.yml
Show resolved
Hide resolved
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
python-avd/pyavd/_eos_designs/structured_config/connected_endpoints/utils.py
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/schema/schema_fragments/network_ports.schema.yml
Outdated
Show resolved
Hide resolved
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one comment and good to go
thanks @kpbush30 for this PR!
Change Summary
Add platform match criteria for network_ports
Related Issue(s)
Fixes #4786
Component(s) name
arista.avd.eos_designs
Proposed changes
Add platform key to match to filter devices for
network_ports
How to test
Run molecule scenario for
eos_designs_uni_tests
forNETWORK_PORTS_TESTS
molecule converge -s eos_designs_unit_tests -- --limit NETWORK_PORTS_TESTS
Checklist
Repository Checklist