Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpi5b: drop LINUXFAMILY=bcm2712 as it is exactly the same as bcm2711 #7642

Conversation

rpardini
Copy link
Member

@rpardini rpardini commented Jan 3, 2025

rpi5b: drop LINUXFAMILY=bcm2712 as it is exactly the same as bcm2711

  • rpi5b: drop LINUXFAMILY=bcm2712 as it is exactly the same as bcm2711
    • in f3f10a9 the 16k-page stuff was dropped
      • and that was the only reason for a separate kernel
      • thus drop the change and unify; 2 less kernels to build and same result

@rpardini rpardini marked this pull request as ready for review January 3, 2025 09:58
@rpardini rpardini requested a review from igorpecovnik as a code owner January 3, 2025 09:58
@github-actions github-actions bot added size/small PR with less then 50 lines Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... labels Jan 3, 2025
@pyavitz
Copy link
Collaborator

pyavitz commented Jan 3, 2025

The problem if I recall correctly? had something to do with the armbian-ramlog service making the unit run wonky. The unit would freeze up, not reboot, apt upgrade didn't work. Stuff like this... The only solution found at the time was disabling the service.

So it was decided to drop 16K.

@rpardini
Copy link
Member Author

rpardini commented Jan 3, 2025

Yeah that makes sense, thanks for the context.

In practice, changing the LINUXFAMILY (with no other changes) just forces a separate kernel build and .deb's to be created (and since both current and edge are enabled, 2x)

@pyavitz
Copy link
Collaborator

pyavitz commented Jan 3, 2025

Yeah that makes sense, thanks for the context.

In practice, changing the LINUXFAMILY (with no other changes) just forces a separate kernel build and .deb's to be created (and since both current and edge are enabled, 2x)

The idea at the time was that a solution would present itself. Since no one has complained about it and the behaviour hasn't occurred since, it has been forgotten about.

#6461

@rpardini rpardini force-pushed the pr/rpi5b-drop-LINUXFAMILYbcm2712-as-it-is-exactly-the-same-as-bcm2711 branch from 70b725d to 093fd7a Compare January 3, 2025 23:31
- in f3f10a9 the 16k-page stuff was dropped
  - and that was the only reason for a separate kernel
  - thus drop the change and unify; 2 less kernels to build and same result
@rpardini rpardini force-pushed the pr/rpi5b-drop-LINUXFAMILYbcm2712-as-it-is-exactly-the-same-as-bcm2711 branch from 093fd7a to 6e1efe3 Compare January 4, 2025 16:33
@igorpecovnik
Copy link
Member

What to do here? Proceed with merging?

@rpardini
Copy link
Member Author

rpardini commented Jan 5, 2025

It's 2 less kernels/.debs to build, with exactly the same result, so I'd say we can merge.

@igorpecovnik igorpecovnik added Ready to merge Reviewed, tested and ready for merge 02 Milestone: First quarter release and removed Needs review Seeking for review labels Jan 5, 2025
@rpardini rpardini merged commit bc38307 into armbian:main Jan 5, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
02 Milestone: First quarter release Hardware Hardware related like kernel, U-Boot, ... Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines
Development

Successfully merging this pull request may close these issues.

3 participants