Fix several panics in ParseCalendar

[brackendawson]

I was trying to Fuzz webcal-proxy but I need golang-ical to be panic free first.

[arran4]

Thanks. Looks good. Running tests.

[arran4]

Shouldn't this be t.Errorf?

[brackendawson]

No, returning an error is fine, most of the corpus data will be invalid ics. Only a panic is a failure here. I added the log line because I wanted to see the errors I wrote using go test -v.

[arran4]

Acknowledged. I haven't used the fuzzing feature myself. Not nearly enough go coding these days.

[arran4]

Tests are failing for pre-fuzzing go. Perhaps use build tags?

Something like:

// +build go1.18

But that is not correct as it isn't forwards compatible I think. I rarely use go version build constraints

[arran4]

Hrm.. Should modify the github workflow action to test on more recent versions of go as well.

[brackendawson]

Hrm.. Should modify the github workflow action to test on more recent versions of go as well.

I notice you test from 1.14 but the go directive in the mod file is 1.13.

[arran4]

Cool all tests pass.

I notice you test from 1.14 but the go directive in the mod file is 1.13.

Interesting. I didn't notice. That would have happened by accident over time rather than intentional. I don't see a reason to change it right now but will accept a PR/change that pushes the matrix back.

[arran4]

LGTM

[arran4]

% git-tag-inc release && git push --tags
Largest: v0.2.3 (51fa6f12130177fd8e6ef8e6e5fcc79e28141324)
Creating v0.2.4
warning: not sending a push certificate since the receiving end does not support --signed push
Enumerating objects: 1, done.
Counting objects: 100% (1/1), done.
Writing objects: 100% (1/1), 155 bytes | 155.00 KiB/s, done.
Total 1 (delta 0), reused 0 (delta 0), pack-reused 0
To https://github.com/arran4/golang-ical.git
 * [new tag]         v0.2.4 -> v0.2.4

Tagged to release for you