Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config class #4

Merged
merged 12 commits into from
Aug 21, 2024
Merged

Conversation

nkongenelly
Copy link
Contributor

No description provided.

@nkongenelly nkongenelly requested a review from Aratz July 18, 2024 09:07
@Aratz
Copy link
Contributor

Aratz commented Aug 1, 2024

@nkongenelly this branch now has conflicts with main 🙈 Could you please look into it?

@nkongenelly
Copy link
Contributor Author

Thanks for the reminder. I have now rebased the code.

Copy link
Contributor

@Aratz Aratz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realized using Config.from_yaml actually made things more complicated than I intended, so I removed it and cleaned up a little bit. Otherwise I think it looks good 👍

@Aratz Aratz merged commit f144191 into arteria-project:main Aug 21, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants