-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add config class #4
Conversation
415f04f
to
f0a13ca
Compare
@nkongenelly this branch now has conflicts with |
Removed files that should not have been commited
9832645
to
52a5716
Compare
Thanks for the reminder. I have now rebased the code. |
It makes `get_app` easier to test if it gets the config as a dictionnary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realized using Config.from_yaml
actually made things more complicated than I intended, so I removed it and cleaned up a little bit. Otherwise I think it looks good 👍
No description provided.