Improve test coverage #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no reason why this handlers would return 404. If no runfolders are found, it should just return an empty list. If another exception pops up, it will be for a different reason and should be converted to an Internal Error (500) (which aiohttp does automatically). Same goes for `/runfolders/pickup` and `/runfolders/next`
This warning should be emitted when no metadata is found, this not only occurs when run_parameters is empty, but also if it does not contain any of the fields we look for.
This uncovered the following bug: if the instrument is not recognized, we can't know its name.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7 +/- ##
===========================================
+ Coverage 92.59% 100.00% +7.40%
===========================================
Files 8 8
Lines 243 230 -13
===========================================
+ Hits 225 230 +5
+ Misses 18 0 -18 ☔ View full report in Codecov by Sentry. |
This runfolder has a run_parameter file, but no complete marker file
|
Actually, I know we've discussed that before here, but I think I've changed my mind. I think |
nkongenelly
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the overall test coverage. While working on this, I've fixed the following issues:
/runfolders,/runfolder/nextand/runfolder/pickupnever have to return404 Not Found. If there is no runfolder to return, they should simply return an empty list or204 No Content.Runfolder, we can assume this attribute exists in all the other methods.