Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: currency formating & ci: container release #11

Merged
merged 5 commits into from
Oct 5, 2024
Merged

feat: currency formating & ci: container release #11

merged 5 commits into from
Oct 5, 2024

Conversation

heronimus
Copy link
Member

@heronimus heronimus commented Oct 4, 2024 •
edited
Loading

Issues

Changes

  • Support currency format for USD/IDR using locale
  • Release container image (ghcr.io) & docker-compose file
  • Dynamic precision point (based on value returned from Coingecko API)

Previous price output:
image

New formatted output:
image

@heronimus heronimus force-pushed the heronimus/currency-formatting branch from da221ed to 29bb9f0 Compare October 4, 2024 09:24
@heronimus heronimus requested a review from igprad October 4, 2024 11:09
@igprad igprad merged commit f520774 into main Oct 5, 2024
2 checks passed
@igprad igprad deleted the heronimus/currency-formatting branch October 5, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igprad igprad igprad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heronimus @igprad