Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add React JS + Webpack example #276

Closed
wants to merge 2 commits into from
Closed

Add React JS + Webpack example #276

wants to merge 2 commits into from

Conversation

Mivr
Copy link
Contributor

@Mivr Mivr commented Aug 20, 2023

Type of change

  • New feature or functionality: Added a new example

Test plan

  • Covered by existing test cases

Related issue: #83

I added a JS React example using Webpack and rules_webpack.
SWC and rules_swc are used for transpiling from JSX to JS.

@CLAassistant
Copy link

CLAassistant commented Aug 20, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I'm moving these examples "upstream" to https://github.com/bazelbuild/examples/tree/main/frontend - would you like to make a PR there, or I can merge this one and then move it myself.

@Mivr
Copy link
Contributor Author

Mivr commented Sep 28, 2023

I am OK with both options. As you decide, just ping me if I have to move it.

@Mivr
Copy link
Contributor Author

Mivr commented Dec 3, 2023

Closing this in favor of: bazelbuild/examples#369

@Mivr Mivr closed this Dec 3, 2023
alexeagle pushed a commit to bazelbuild/examples that referenced this pull request Dec 3, 2023
Related to aspect-build/bazel-examples#276 and
aspect-build/bazel-examples#83

This PR adds a react JS Webpack example using SWC for transpilation and
Webpack for bundling.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants