Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auctioneer): add new service #1839

Open
wants to merge 42 commits into
base: main
Choose a base branch
from
Open

Conversation

SuperFluffy
Copy link
Member

@SuperFluffy SuperFluffy commented Nov 29, 2024

Summary

This patch adds the Astria Auctioneer service to the monorepo.

Background

The Astria Auctioneer auctions the top of the next Rollup to the highest bidder.

It receives a proposed Sequencer block1 via a Sequencer node's astria.sequencerblock.optimistic.v1alpha1.OptimisticBlock service, and forwards it to its Rollup node's astria.auction.v1alpha1.OptimisticExecutionService for optimistic execution by the Rollup. The executed optimistic block hash returned by the rollup triggers Auctioneer to start an auction. It then receives bids from the Rollup node's astria.auction.v1alpha.AuctionService, selecting the winner using a first-price mechanism.

The auction winner is finally submitted to the same Sequencer node using a standard ABCI broadcast_tx_sync to the Sequencer network.

Auctioneer does not act as a server in its own right but connects as a client to a Rollup node and to a Sequencer node.

Changes

  • Add crate crates/astria-auctioneer. It is implemented as a simple event loop that multiplexes proposed blocks and finalized commits (from sequencer), as well as executed rollup blocks and bids (from the rollup).
  • Bump workspace dependency tokio_utils to 0.7.13 to get access to CancellationToken::run_until_cancelled
  • Rename execution APIs astria.bundle to astria.auction
  • Add domain type SequencerBlockCommit to new astria_core::sequencerblock::optimistic::v1alpha1 submodule, following protobuf spec naming conventions (the other domain types remain exclusive to auctioneer for now).
  • Implement astria_core::Protobuf for FilteredSequencerBlock to get access to the wiretype name in error and log messages.
  • Refactor astria_sequencer::sequencer::start_grpc_server to astria-sequencer::grpc::serve
  • Add module astria_sequencer::grpc::optimistic implementing the astria.sequencerblock.optimistic.v1alpha1.OptimisticBlock gRPC service
  • Refactor astria_sequencer::app module to implement an EventBus that is used by the gRPC service to subscribe to new events (right now, only proposed blocks and commits).
  • Add setting ASTRIA_SEQUENCER_NO_OPTIMISTIC_BLOCKS to toggle the optimistic block service in Sequencer
  • Add chart charts/auctioneer
  • Update charts/evm-rollup/files/genesis/geth-genesis.json to set astriaAuctioneerAddresses
  • Update charts/sequencer/templates/configmaps.yaml to to set ASTRIA_SEQUENCER_NO_OPTIMISTIC_BLOCKS
  • Update justifle to understand how to docker-build auctioneer
  • Add job auctioneer to docker-build github workflow.

Testing

To test this, we deployed a local setup consisting of a dedicated auctioneer flame node, the auctioneer node and a sequencer with optimistic blocks enabled.
The code for auctioneer flame node can be found at astriaorg/flame#30. The auctioneer has been tested locally against this auctioneer flame node branch.
We have tested the setup by sending txs to the auctioneer flame node using spamooor. We check with logs and manually query the blocks to ensure that the tx sent has end up on the top of block of the auctioneer.

Changelogs

Changelogs updated.

Related Issues

closes #1888
closes #1533
closes #1820

Footnotes

  1. A proposed Sequencer block is that data structure that comes out of the Astria Sequencer network's CometBFT process-proposal step.

@github-actions github-actions bot added conductor pertaining to the astria-conductor crate sequencer pertaining to the astria-sequencer crate labels Dec 2, 2024
@github-actions github-actions bot added documentation Improvements or additions to documentation proto pertaining to the Astria Protobuf spec sequencer-relayer pertaining to the astria-sequencer-relayer crate composer pertaining to composer cd labels Dec 5, 2024
@SuperFluffy SuperFluffy changed the base branch from itamarreif/auctioneer/eng-824 to main January 7, 2025 13:15
@SuperFluffy SuperFluffy removed conductor pertaining to the astria-conductor crate sequencer-relayer pertaining to the astria-sequencer-relayer crate composer pertaining to composer labels Jan 14, 2025
@SuperFluffy SuperFluffy requested review from Fraser999 and removed request for noot January 14, 2025 18:16
Copy link
Collaborator

@noot noot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sequencer side changes look good to me!

crates/astria-core/CHANGELOG.md Outdated Show resolved Hide resolved
crates/astria-sequencer/src/app/event_bus.rs Outdated Show resolved Hide resolved
crates/astria-sequencer/src/app/event_bus.rs Outdated Show resolved Hide resolved
crates/astria-sequencer/src/app/event_bus.rs Outdated Show resolved Hide resolved
crates/astria-sequencer/src/app/event_bus.rs Outdated Show resolved Hide resolved

impl EventBusSubscription {
pub(crate) fn process_proposal_blocks(&mut self) -> EventReceiver<Arc<SequencerBlock>> {
self.process_proposal_blocks.clone()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like when we call this method, the caller always has to immediately call mark_latest_event_as_seen. if so, it would be better to just do that inside here (and in finalized_blocks just below), meaning we could remove the mark_latest_event_as_seen method altogether.

Suggested change
self.process_proposal_blocks.clone()
let mut receiver = self.process_proposal_blocks.clone();
receiver.inner.mark_unchanged();
receiver

Copy link
Member Author

@SuperFluffy SuperFluffy Jan 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that makes sense and is actually in line with how the EventBus is described to work. 49d3be4

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like removing mark_latest_event_as_seen was missed?

crates/astria-sequencer/src/app/event_bus.rs Outdated Show resolved Hide resolved
crates/astria-sequencer/src/app/event_bus.rs Outdated Show resolved Hide resolved
crates/astria-sequencer/src/app/event_bus.rs Outdated Show resolved Hide resolved
crates/astria-sequencer/src/grpc/mod.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@Fraser999 Fraser999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optimistic approval of the sequencer and core code, pending addressing one minor comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auctioneer cd ci issues that are related to ci and github workflows documentation Improvements or additions to documentation proto pertaining to the Astria Protobuf spec sequencer pertaining to the astria-sequencer crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up names in Bundle API Build auctioneer docker image in CI Astria Auctioneer MVP
5 participants