chore(sequencer): remove misplaced logs #1892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperFluffy
force-pushed
the
superfluffy/remove-confusing-logs
branch
from
a5c2e4d to
0d228bf
Compare
Sequencer checks if the storage path exists and then reports on actions that it thinks what the call `cnidarium::Storage::load` will do. However, on the one hand cnidarium itself already reports that information. On the other hand, `Sequencer::run_until_stopped` is the wrong place to emit these events because it does not have authority over which actions cnidarium will take. Should the construct ever change, then the events will be immediately out of whack, which will lead to confusion.
SuperFluffy
force-pushed
the
superfluffy/remove-confusing-logs
branch
from
0d228bf to
85a1621
Compare
Fraser999
approved these changes
Jan 8, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove events from
Sequencer::run_until_stoppedthat report on whether whether a state DB will be
opened or created.
Background
Cnidarium already reports which paths it will read.
More egregious however is that
Sequencer::run_until_stoppedis the wrong placeto emit these events because it does not have
authority over which actions cnidarium will take.
Should the constructor ever change, then the events
will be immediately out of whack, which will lead
to confusion.
Changes
Sequencer::run_until_stopped.Testing
No testing necessary. These are just some limited events.
Changelogs
Changelogs updated.