chore(core, sequencer): Create price feed enum action and nest relevant actions inside #1900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
proto
noot
approved these changes
Jan 15, 2025
noot
reviewed
Jan 15, 2025
Comment on lines
258
to
264
| message CurrencyPairsToAdd { | ||
| repeated connect.types.v2.CurrencyPair pairs = 1; | ||
| } | ||
|
|
||
| message RemoveCurrencyPairs { | ||
| message CurrencyPairsToRemove { | ||
| repeated connect.types.v2.CurrencyPair pairs = 1; | ||
| } |
There was a problem hiding this comment.
nit but since these two are the same type, can we use just one type CurrencyPairs and determine addition or removal based on enum variant?
There was a problem hiding this comment.
Good point. Done in 1180e60.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This unflattens the two closely-related price feed actions into a new enum.
Background
We want to be consistent with other existing actions where we group related actions under a parent enum. This will help avoid the main action enum becoming too cluttered over time.
Changes
PriceFeedaction enum, in anticipation of another variant (MarketMap) being added soon to support actions affecting the market map.CurrencyPairsChangeenum which subsumes the recently-addedAddCurrencyPairsandRemoveCurrencyPairsaction structs.PriceFeedaction belonging to more than one group when the market map actions are included.Testing
No new tests required, existing tests refactored as required.
Changelogs
No updates required.
Related Issues
Closes #1896.