Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates for new cli features #21

Merged
merged 10 commits into from
Oct 24, 2023
Merged

Updates for new cli features #21

merged 10 commits into from
Oct 24, 2023

Conversation

sambukowski
Copy link
Contributor

@sambukowski sambukowski commented Oct 23, 2023 •
edited
Loading

Description

Updates and simplification to docs to reflect new functionality of astria-cli

Motivation and Context

  • updated "modify helm chart sections
  • updated to "using the cli sections
  • updated create rollup config sections
  • updated and added information about auto fetching sequencer block height
  • updated the setting of env vars related to k8s namespaces

Types of changes

  • Edits to existing documentation
  • Changing documentation structure (relocating existing files, ensure redirects exist)
  • Stylistic changes (provide screenshots above)

closes #19
closes #20

@jbowen93 jbowen93 marked this pull request as ready for review October 24, 2023 16:41
@jbowen93 jbowen93 requested a review from joroshiba October 24, 2023 16:41
WafflesVonMaple
WafflesVonMaple reviewed Oct 24, 2023
View reviewed changes
docs/dusknet/cloud-rollup-deployment/1-digital-ocean.md Outdated
websocket: wss://rpc.sequencer.dusk-1.devnet.astria.org/websocket
rpc: https://rpc.sequencer.dusk-1.devnet.astria.org
ingress:
hostname: niven.io
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<YOUR_HOSTNAME>

WafflesVonMaple
WafflesVonMaple approved these changes Oct 24, 2023
View reviewed changes
Copy link

@WafflesVonMaple WafflesVonMaple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one nit on hostname in digitalocean instructions

@jbowen93
Copy link
Member

just one nit on hostname in digitalocean instructions

fixed. Will merge assuming checks pass.

@jbowen93 jbowen93 merged commit e9b486e into main Oct 24, 2023
2 checks passed
@jbowen93 jbowen93 deleted the cli-namespace-block-height-additions branch October 24, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WafflesVonMaple WafflesVonMaple WafflesVonMaple approved these changes

@joroshiba joroshiba Awaiting requested review from joroshiba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update CLI command usage to reflect auto grabbing sequencer block height Update Update helm chart sections.
3 participants
@sambukowski @jbowen93 @WafflesVonMaple