Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove privatekey: from the protocol specification #131

Closed
JeremyTubongbanua opened this issue Feb 14, 2024 · 4 comments · Fixed by #166
Closed

Remove privatekey: from the protocol specification #131

JeremyTubongbanua opened this issue Feb 14, 2024 · 4 comments · Fixed by #166
Assignees

Comments

@JeremyTubongbanua
Copy link
Member

@gkc says privatekey: is obsolete and is never used.

The objective of this ticket is to remove privatekey: documentation from the protocl specification and remove it from any regex patterns.

@JeremyTubongbanua JeremyTubongbanua self-assigned this Feb 14, 2024
@JeremyTubongbanua JeremyTubongbanua changed the title Remove privatekey: from the protocl specification Remove privatekey: from the protocol specification Feb 14, 2024
@gkc gkc self-assigned this Mar 18, 2024
@JeremyTubongbanua
Copy link
Member Author

@gkc I can pick this up this sprint PR 87

@gkc
Copy link
Contributor

gkc commented May 13, 2024

@JeremyTubongbanua sounds good thank you

@gkc gkc removed their assignment May 13, 2024
@JeremyTubongbanua
Copy link
Member Author

JeremyTubongbanua commented Jul 9, 2024

@XavierChanth I had a PR on this here : #133

feel free to overwrite or close or whatever to the branch/PR

@XavierChanth
Copy link
Member

@XavierChanth I had a PR on this here : #133

feel free to overwrite or close or whatever to the branch/PR

Thanks, I didn't see this until after, but I've ended up with very similar changes + some other changes I was making to other things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants