Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: spec v1.0.0 #166

Merged
merged 8 commits into from
Jul 22, 2024
Merged

docs: spec v1.0.0 #166

merged 8 commits into from
Jul 22, 2024

Conversation

XavierChanth
Copy link
Member

@XavierChanth XavierChanth commented Jul 15, 2024

closes #131
closes #158

- What I did

  • Renamed / reorganized the 5 key types

    • Breaking change: replaced privatekey with self key.
    • The keys are in two groups:
      • Public, Self, Shared
      • Augmented keys: Hidden, Cached
  • Reorganized verbs into Auth, CRUD, notifications, misc

  • moved info/noop from beta to stable as misc verbs

- How I did it

- How to verify it

- Description for the changelog
docs: spec v1.0.0

- Format to max 80 char lines
- Reorganized verbs into Auth, CRUD, notifications, misc
- moved info/noop from beta to stable as misc verbs
@XavierChanth XavierChanth changed the title docs: spec v1.0.0- docs: spec v1.0.0 draft Jul 15, 2024
@XavierChanth XavierChanth changed the title docs: spec v1.0.0 draft docs: spec v1.0.0 Jul 15, 2024
@XavierChanth XavierChanth requested review from gkc and cpswan July 15, 2024 13:53
@XavierChanth
Copy link
Member Author

I am fixing these lint issues, formatter messed with spacing around comments

@XavierChanth XavierChanth requested a review from cconstab July 15, 2024 15:32
cpswan
cpswan previously approved these changes Jul 15, 2024
@XavierChanth
Copy link
Member Author

I set this PR to draft to clarify some things in the PR which should be linked right above this comment.

@XavierChanth XavierChanth force-pushed the spec-v1-0-0 branch 2 times, most recently from 87ff7e6 to f42dd39 Compare July 15, 2024 22:30
@XavierChanth XavierChanth marked this pull request as ready for review July 15, 2024 22:47
@XavierChanth
Copy link
Member Author

Ready for review

gkc
gkc previously approved these changes Jul 18, 2024
specification/at_protocol_specification.md Outdated Show resolved Hide resolved
@XavierChanth XavierChanth merged commit cb3c2fa into trunk Jul 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update protocol spec Remove privatekey: from the protocol specification
3 participants