Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Create 2024-06-packages-depencency-update-interval.md #156

Merged
merged 6 commits into from
Jul 15, 2024

Conversation

CurtlyCritchlow
Copy link
Contributor

@CurtlyCritchlow CurtlyCritchlow commented Jun 18, 2024

- What I did
Created an ADR on updating our packages dependencies

- How I did it

- How to verify it
Read 2024-06-packages-depencency-update-interval.md

- Description for the changelog
chore: added 2024-06-packages-depencency-update-interval.md

@CurtlyCritchlow CurtlyCritchlow requested a review from cpswan June 18, 2024 17:00
@CurtlyCritchlow CurtlyCritchlow self-assigned this Jun 18, 2024
@cpswan cpswan requested review from gkc and XavierChanth June 19, 2024 09:19
@gkc gkc changed the title chore: Create 2024-06-packages-depencency-update-inerval.md chore: Create 2024-06-packages-depencency-update-interval.md Jun 24, 2024
@cpswan
Copy link
Member

cpswan commented Jul 10, 2024

@gkc and @XavierChanth this is still awaiting review

I'm happy with it (after revisions in 0657540), but I can't mark my own homework.

XavierChanth
XavierChanth previously approved these changes Jul 15, 2024
Copy link
Member

@XavierChanth XavierChanth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CurtlyCritchlow Please change the status in the document from draft to approved and I will reapprove the PR

@gkc gkc merged commit 8e431df into trunk Jul 15, 2024
2 checks passed
@gkc gkc deleted the decision/update-package-dependency-quarterly branch July 15, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants