Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: language support added for es, pt, mandarin and cantonese #949

Merged

Conversation

CurtlyCritchlow
Copy link
Contributor

@CurtlyCritchlow CurtlyCritchlow commented Nov 28, 2024

…ntonese in at_onboarding_flutter.

- What I did
closes #945
Updated the readme.md and app version to version and 6.10.
- How I did it

- How to verify it

- Description for the changelog

Language support added for Spanish (latin American), Portuguese (European and Brazillian) and Chinese ( mandarin and cantonese)

@CurtlyCritchlow CurtlyCritchlow marked this pull request as ready for review November 28, 2024 15:51
@@ -0,0 +1,114 @@
{
"activate_an_atSign": "激活一个@符号",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look quite right, atSign got translated, make sure it still means "atSign" and not "at sign"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for other localizations

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, addressed it for all the languages to keep atSign as a proper noun.

Copy link
Member

@XavierChanth XavierChanth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments

@CurtlyCritchlow CurtlyCritchlow merged commit 3b22ed2 into at_onboarding_flutter_layers Dec 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants