Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure tag-exists works as intended #752

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Conversation

frederikprijck
Copy link
Member

Changes

The tag-exists action was not working due to the fact that it was trying to read from a step that did not exist.
Without these changes, it would always 404 and act as if the tag doesn't exist.

Checklist

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (957c786) 100.00% compared to head (e96724c) 100.00%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##                main      #752   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity      1381      1381           
===========================================
  Files             62        62           
  Lines           4776      4776           
===========================================
  Hits            4776      4776           
Flag Coverage Δ
unittestsvalidate 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frederikprijck frederikprijck merged commit 14b405e into main Dec 13, 2023
24 checks passed
@frederikprijck frederikprijck deleted the frederikprijck-patch-1 branch December 13, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants