More spanner observability / Go Scheduler metrics #1609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vroldanbet
commented
Oct 24, 2023
•
vroldanbet
commented
- adds opentelemetry integration into Spanner client
- exposes Spanner client metrics via prometheus
- enables All Go runtime metrics (including scheduler)
vroldanbet
force-pushed
the
more-spanner-observability
branch
5 times, most recently
from
2788119 to
65b5e32
Compare
This caused an incident as it basically doubles Spanner CPU usage This reverts commit 75b8f9f.
this replaces prometheus client_golang default collector with one that includes Go scheduler metrics
vroldanbet
force-pushed
the
more-spanner-observability
branch
from
81e6af5 to
21b85c7
Compare
vroldanbet
changed the title
ecordell
reviewed
Oct 25, 2023
| // | ||
| // in order to register this, the package must be imported anonymously | ||
| func init() { | ||
| prometheus.DefaultRegisterer.Unregister(collectors.NewGoCollector()) |
There was a problem hiding this comment.
Ah nice, I spent a bunch of time trying to register the scheduler metrics but they kept including metrics that conflicted with existing ones as a side-effect.
There was a problem hiding this comment.
Spent most of the time dealing with the same 😅 We could also create a new promhttp handler with a Gatherer, but would require a different HTTP endpoint and that's a mess. The reason we have to do this is because we rely heavily on the default prometheus Registry - we may want to revisit that.
ecordell
approved these changes
Oct 25, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.