Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve iterative phonon workflow and the output of our phonon workflow #312

Open
JaGeo opened this issue Dec 29, 2024 · 0 comments
Open
Assignees
Labels
phonon affects the phonon workflow only

Comments

@JaGeo
Copy link
Collaborator

JaGeo commented Dec 29, 2024

To reuse more data from the phonon workflow, the following points have to be improved:

[ ] Optimized structures and isolated atoms energies have to be part of the output!
[ ] add better tests for random structure generation and random seeds! The tests should be all testing the poscar as well.
[ ] remove duplicate test data (I copied some data and only adapted poscars for the new tests in #306 )
[ ] remove duplicated optimization for rattled and phonon structures (there should only be one approach in my opinion)

As a follow up to #306

@JaGeo JaGeo added the phonon affects the phonon workflow only label Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
phonon affects the phonon workflow only
Projects
None yet
Development

No branches or pull requests

2 participants