-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt Makers to use pydantic models instead of yamls #307
base: main
Are you sure you want to change the base?
Conversation
Shouldn't we rather do something similar to atomate2 settings? |
Hi @JaGeo , i think both above approach we can use to load the default yamls, which I plan to do next : similar to atomate2 settings But we would still need postinit in the maker if we expect user to provide modified yaml path (so it gets read when the flow is created) and we don't want to copy that yamls to remote cluster. Due to nature of jobflow delayed execution |
@naik-aakash okay! Likely pymatgen approach is th closest to what we want for defaults |
Another thought: post init will not work if you initialize the flow during run time |
Thanks for fixing the bug well @naik-aakash 😉. |
@@ -17,7 +17,7 @@ def test_gap_fit_maker(test_dir, memory_jobstore, clean_dir): | |||
database_dir=database_dir | |||
) | |||
|
|||
responses = run_locally( | |||
_ = run_locally( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why don't we just do run_locally(...)
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests can be made better in future by accessing the responses and assertions.
I can remove it yes. That's true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Up to you, just wondered about it 😄
Closes #305 , #329, #324 and #330
Changes
nequip_fitting
function can be cleaned upmachine_learning_fit
functionM3GNET
andNEQUIP
hyperparametersM3GNET
(only implemented for direct download of m3gnet model using matgl; more parameters need to be added - Later ?)