Skip to content

Commit

Permalink
tests should run trough now
Browse files Browse the repository at this point in the history
  • Loading branch information
KrissiHub committed Nov 22, 2023
1 parent 2fc0361 commit 0d49311
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 11 deletions.
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ repos:
- id: mypy
name: mypy deepcave
files: deepcave
args: [--check-untyped-defs, --ignore-missing-imports, --install-types, --non-interactive]
args: [--install-types, --non-interactive]
additional_dependencies: [
'wheel',
'setuptools',
Expand Down
15 changes: 7 additions & 8 deletions deepcave/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,6 @@
from functools import wraps
from pathlib import Path

from dash_extensions.enrich import (
DashProxy,
MultiplexerTransform,
NoOutputTransform,
TriggerTransform,
)

name = "DeepCAVE"
package_name = "deepcave"
author = "R. Sass and E. Bergman and A. Biedenkapp and F. Hutter and M. Lindauer"
Expand All @@ -41,7 +34,7 @@
ROOT_DIR = Path(__file__).parent


def get_app(title: str) -> DashProxy:
def get_app(title: str) -> Any:
"""
Create the Dash application.
Expand All @@ -56,6 +49,12 @@ def get_app(title: str) -> DashProxy:
The dash application.
"""
import dash_bootstrap_components as dbc
from dash_extensions.enrich import (
DashProxy,
MultiplexerTransform,
NoOutputTransform,
TriggerTransform,
)

app = DashProxy(
__name__,
Expand Down
5 changes: 3 additions & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -53,14 +53,15 @@ add-ignore = [ # http://www.pydocstyle.org/en/stable/error_codes.html
]

[tool.mypy]
python_version = "3.8"
python_version = "3.9"
show_error_codes = true
warn_unused_configs = true # warn about unused [tool.mypy] lines
follow_imports = "normal" # Type check top level api code we use from imports
ignore_missing_imports = true # prefer explicit ignores
ignore_missing_imports = true # prefer explicit ignores
disallow_untyped_defs = true # All functions must have types
disallow_untyped_decorators = true # ... even decorators
disallow_incomplete_defs = true # ... all types
check_untyped_defs = true # Problems are shown, even if def is check_untyped_defs

[[tool.mypy.overrides]]
module = ["setuptools.*"] # Add modules that give import errors here
Expand Down
3 changes: 3 additions & 0 deletions requirements.txt
Original file line number Diff line number Diff line change
@@ -1,10 +1,13 @@
# If something is changed here, change it in the pre-commit-hook under mypy additonal dependencies as well
# otherwise mypy wont check the dependencies
wheel
setuptools
absl-py>=1.0.0
jsonlines>=3.0.0
pandas>=1.3.4
numpy>=1.22.2
matplotlib>=3.5.1
seaborn>=0.13.0
pyyaml

# AutoML packages
Expand Down

0 comments on commit 0d49311

Please sign in to comment.